Fix/unable to decode negative zero int#136
Open
nickccm1122 wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 38 38
Lines 5323 5323
=======================================
Hits 5321 5321
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 38 38
Lines 5323 5323
=======================================
Hits 5321 5321
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Currently this is unable to decode json with value
-0(it throws error). However,{"key": -0}should be a valid JSON and gojay should be able to decode it.What is changed
floatdecoder allows to decode{"key": -0.0}. So I have change thegetInt64Negativethat it also allow to accept0-0test case fordecode_number_int-0.0test case fordecode_number_float